davidmoten / davidmoten/rxjava-extras

onBackpressureBufferToFile review please

Open
#9 7 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Java
Stars
271
Forks
28
Avg merge
2m
Merged PRs (30d)
1

Description

The ability to buffer streams to disk has been something that I've wondered about for a while.

Can I get peoples comments/review of this new operator please?

[`Transformers.onBackpressureBufferToFile`](https://github.com/davidmoten/rxjava-extras/blob/master/README.md#transformersonbackpressurebuffertofile)

I'd love to get review of this new operator in terms of
- what use cases have _you_ got? (volume, serialized size, rate, platform, constraints)
- overall approach
- API
- correctness of code (a big one because of the numerous sections of code subject to concurrency)
- testing on different OS (currently just tested on linux)
- performance (I've favoured correctness initially)
- anything else you think of

The code is in the master branch and runtime jar is on Maven Central as described in rxjava-extras [README](https://github.com/davidmoten/rxjava-extras).

A quick way of contributing is to run a long running test (~30 mins) on your machine:

``` bash
git clone https://github.com/davidmoten/rxjava-extras.git
cd rxjava-extras
./test-long.sh
```

On non-nix platform just run this command instead of `test-long.sh`:

```
mvn clean install -Dmax.small=100000000 -Dmax.medium=300000 -Dmax.seconds=600 -Dloops=10000
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.