davidmerfield / davidmerfield/randomColor

Support for ESM added, then removed?

Open
#160 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
6.1k
Forks
408
PR merge metrics
No merged PRs in 30d

Description

Hey @davidmerfield!

Thanks for this package, it's a neat and simple tool that I find really useful, especially for seeding colors based on inputs.

I wanted to ask a question though: I see ESM support was added in #134 but then shortly after was removed in ff971faaa792736ab386d99c56127e2fa8da11ca. I'm wondering, was that on account of the changes from the PR breaking use of this module in other environments? That seems like what was going on. Since the version of this package available on `npm` is Node-first (non-browser compatible), it makes sense that going fully ESM would cause issues.

Maybe I've answered my own question, but at any rate, ESM-native imports would be a nice thing to have, especially through `npm`. Do you plan on re-adding ESM support in the future (of course, this being open-source I am not asking or demanding anything, just curious if that's a direction you are planning to go in).

Thanks!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.