daveharmswebdev / daveharmswebdev/property-manager

Consider direct vendor-to-receipt relationship (deferred)

Open
#243 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C#
Stars
0
Forks
0
Avg merge
17m
Merged PRs (30d)
1

Description

Summary

During manual testing of receipt processing, the question arose: should receipts have a direct relationship to vendors, or is the indirect linkage through work orders sufficient?

Currently there is no vendor field on receipts. The only path to associate a vendor with a receipt is indirectly: receipt → work order → vendor.

Discussion

Arguments for keeping indirect-only (via work order):

  • Simpler data model — no new FK on receipts table
  • Enforces process discipline: every expense has context through a work order
  • Avoids multiple paths to the same outcome
  • Easier reporting and data reasoning

Arguments for adding direct vendor-on-receipt:

  • Not every receipt originates from a work order (supply runs, one-off purchases)
  • Users may think in terms of "I paid this vendor" not "I paid this work order"
  • Enables direct querying: "show me everything I've paid Vendor X"

Decision

Deferred. The indirect path through work orders covers the primary use case. No action until beta testers surface a need for direct vendor-receipt linkage.

This issue exists to document that the relationship was considered and intentionally deferred — not overlooked.

Origin

Discovered while executing TC-REC-008 (Inline Vendor Creation during receipt processing) — that test case describes a feature that does not exist and should be reviewed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

This is a recorded decision, not an implementation task. Start by reviewing TC-REC-008, which the issue identifies as describing a nonexistent feature. Done means the test case is reviewed and the deferred vendor-receipt decision remains accurately documented.

Written by the indexing model from the issue text.

Assessment

Domain
database
Issue type
Documentation
Difficulty
1/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.