datatheorem / datatheorem/TrustKit

Thread 1: "TrustKit was initialized with an invalid domain 5X.X3X.1X4.XXX"

Open
#341 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
Objective-C
Stars
2.1k
Forks
381
PR merge metrics
No merged PRs in 30d

Description

Greetings community, would it be possible to add any additional properties or settings to be able to add an IP address as a domain in TrustKit? It would be very helpful.

let trustKitConfig: [String: Any] = [
kTSKSwizzleNetworkDelegates: true,
kTSKPinnedDomains: [
"5X.X3X.1X4.XXX": [
kTSKIncludeSubdomains: true,
kTSKEnforcePinning: true,
kTSKDisableDefaultReportUri: true,
kTSKPublicKeyHashes: [
"sha256/cXXXXXXX8d1cba4028XXXXXXXXXXXXXXXX"
]
]
]
]

   TrustKit.initSharedInstance(withConfiguration:trustKitConfig)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named in the issue. Start by locating TrustKit’s configuration validation for pinned-domain keys and the handling of invalid domains; done means an IP address can be accepted for pinning without the reported initialization error.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, objective-c, swift
Domain
mobile-dev, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.