datatheorem / datatheorem/TrustKit

If switch the calendar on your phone to the Japanese calendar, it may cause a date format error.

Open
#322 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Objective-C
Stars
2.1k
Forks
381
PR merge metrics
No merged PRs in 30d

Description

If you switch the calendar on your phone to the Japanese calendar, it may cause a date format error. In the code snippet domainFinalConfiguration[kTSKExpirationDate] = expirationDate;, the expiration date might appear as the year 4041, leading to the expiration time not taking effect.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the expiration-date assignment at domainFinalConfiguration[kTSKExpirationDate] in the TrustKit iOS code. Reproduce the behavior with the Japanese calendar enabled and inspect how the date is converted before expiration is enforced. Done means the expiration date is interpreted correctly rather than appearing as year 4041, and the expiration time takes effect.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, objective-c
Domain
mobile-dev, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.