datatheorem / datatheorem/TrustKit
Revamp the logging block override mechanism
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 2.1k
- Forks
- 381
- PR merge metrics
- No merged PRs in 30d
Description
In version 1.5.0, the + [TrustKit setLoggerBlock:] method does not really make sense anymore now that TrustKit can be used in non-singleton mode.
The logger block will always be applied to all TrustKit instances, although the way the API is designed (as a class method) makes it look like it only applies to the singleton instance. This is confusing and inconsistent.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Objective-C +[TrustKit setLoggerBlock:] API and how logger blocks are applied across singleton and non-singleton TrustKit instances. The issue does not name implementation files or tests, so locate the logger configuration and instance-construction paths first; done means the override behavior and API semantics are consistent for both usage modes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100