datatheorem / datatheorem/TrustKit-Android
Volley and Truskit blocking other domains
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 604
- Forks
- 90
- Avg merge
- 1h 29m
- Merged PRs (30d)
- 2
Description
Hello,
I have implemented certificate pinning with Trustkit, Volley and the config file network_security_config.xml, which look like :
<network-security-config>
<domain-config>
<domain includeSubdomains="true">preprod.com</domain>
<pin-set expiration="2050-12-12">
<pin digest="SHA-256">AAAAAAAAAAAAA</pin>
<pin digest="SHA-256">BBBBBBBBBBBBB</pin>
</pin-set>
<trustkit-config enforcePinning="true"/>
</domain-config>
<domain-config>
<domain includeSubdomains="true">prod.com</domain>
<pin-set expiration="2050-12-12">
<pin digest="SHA-256">CCCCCCCCCCCC</pin>
<pin digest="SHA-256">DDDDDDDDDDDD</pin>
</pin-set>
<trustkit-config enforcePinning="true"/>
</domain-config>
</network-security-config>
It is working perfectly when I am calling urls like .prod.com/ or .preprod.com/ but when I want to call another domain it is blocking everything. Is there a way to fix the configuration ?
Thanks
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with network_security_config.xml and reproduce a Volley request to a domain other than prod.com or preprod.com. Trace how TrustKit and Volley handle domains outside the two domain-config blocks; done means the configured domains remain pinned while requests to other domains are no longer blocked.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- mobile-dev, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100