datatheorem / datatheorem/TrustKit-Android
TrustKit-Android can’t support multi <domain> under the same <domain-config>
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 604
- Forks
- 90
- Avg merge
- 1h 29m
- Merged PRs (30d)
- 2
Description
Is your feature request related to a problem? Please describe.
TrustKit-Android can’t support multi under the same
This means it only deploys SSL public key pinning at the last domain, for example
<domain-config>
<domain includeSubdomains="true">google.com</domain>
<domain includeSubdomains="true">yahoo.com</domain>
<domain includeSubdomains="true">verizon.com</domain>
<pin-set>
<pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
<pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
</pin-set>
</domain-config>
TrustKit only verifies the domain verizon.com’s certificate chain. Neither google.com nor yahoo.com
Describe the solution you'd like
Because TrustKit Android works by extending the Android N Network Security Configuration, it is good to support multi under the same
Describe alternatives you've considered
If we want to enable SSL pinning to multi domain, even the same certificate chain, we need to separate the domain-config
<domain-config>
<domain includeSubdomains="true">google.com</domain>
<pin-set>
<pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
<pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
</pin-set>
</domain-config>
<domain-config>
<domain includeSubdomains="true">yahoo.com</domain>
<pin-set>
<pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
<pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
</pin-set>
</domain-config>
<domain-config>
<domain includeSubdomains="true">verizon.com</domain>
<pin-set>
<pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
<pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
</pin-set>
</domain-config>
Additional context
We can refer its test cases:
https://github.com/datatheorem/TrustKit-Android/blob/master/trustkit/src/androidTest/res/xml/network_security_config.xml
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with trustkit/src/androidTest/res/xml/network_security_config.xml, the test resource referenced in the issue, and review its existing multi-domain cases. Add coverage for multiple domains under one domain-config, then verify that pinning applies to google.com, yahoo.com, and verizon.com rather than only the last domain.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100