datatheorem / datatheorem/TrustKit-Android

Initialization fails on Android 7 Instant App

Open
#67 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
604
Forks
90
Avg merge
1h 29m
Merged PRs (30d)
2

Description

Describe the bug
Hi, there seems to be an Android framework issue when building instant app on Android 7 where Truskit fails to initialize.
After debugging, the root cause is coming from parsing the ApplicationInfo in this [method].(https://github.com/datatheorem/TrustKit-Android/blob/master/trustkit/src/main/java/com/datatheorem/android/trustkit/TrustKit.java#L231)
When building instant app project, Android 7 somehow fails to create networkSecurityConfigRes=0x. This doesn't happen on the traditional app.

To Reproduce
Here is the branch of a sample instant app modules:
https://github.com/chihweil5/TrustKit-Android/tree/instant-app

The quick tryout solution I made is by changing this condition here, both instant app and app are working on Android 7. I am not sure if this is a proper fix although. Thanks in advance for looking into this issue!

App details:

  • App target SDK: [e.g. 24]
  • App language: [e.g. Kotlin]
  • Android version to reproduce the bug [e.g. Android N]

Thank you!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with TrustKit.java at the ApplicationInfo parsing method around line 231 and the condition around line 292. Reproduce the issue using the linked instant-app branch on Android 7, then verify that both instant-app and traditional-app initialization succeed without breaking the existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.