Default plain-text ingestion fails on empty lines
Open
Nobody has claimed this yet.
discussion
- Dominant language
- C#
- Stars
- 167
- Forks
- 30
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 9
Description
E.g. in PowerShell, in a non-empty folder, running:
ls | seqcli ingest
Produces:
Ingestion failed: A line arrived late or could not be parsed: ``.
System.IO.InvalidDataException: A line arrived late or could not be parsed: ``.
at SeqCli.PlainText.PlainTextLogEventReader.TryReadAsync() in C:\projects\seqcli\src\SeqCli\PlainText\PlainTextLogEventReader.cs:line 36
at SeqCli.Ingestion.LogShipper.ReadBatchAsync(ILogEventReader reader, Func`2 filter, Int32 count, InvalidDataHandling invalidDataHandling) in C:\projects\seqcli\src\SeqCli\Ingestion\LogShipper.cs:line 94
at SeqCli.Ingestion.LogShipper.ShipEvents(SeqConnection connection, ILogEventReader reader, List`1 enrichers, InvalidDataHandling invalidDataHandling, SendFailureHandling sendFailureHandling, Func`2 filter) in C:\projects\seqcli\src\SeqCli\Ingestion\LogShipper.cs:line 50
at SeqCli.Cli.Commands.IngestCommand.Run() in C:\projects\seqcli\src\SeqCli\Cli\Commands\IngestCommand.cs:line 90
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure with ls | seqcli ingest, then inspect src/SeqCli/PlainText/PlainTextLogEventReader.cs around line 36 and the ingestion path shown in the stack trace. Done means default plain-text ingestion no longer fails when the input contains empty lines.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100