dataiku / dataiku/kiji-proxy

CLA Assistant workflow fails on every non-PR issue comment (missing if-gate)

Open Beginner friendly
#596 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
432
Forks
51
PR merge metrics
No merged PRs in 30d

Description

Summary

The CLA Assistant workflow fails on every comment posted to a plain (non-PR) issue. .github/workflows/cla.yml triggers on issue_comment, which fires for comments on both issues and pull requests, and the job has no condition filtering out the former. The cla-assistant action then assumes a PR context and errors:

##[error]graphql call to get the committers details failed: GraphqlError: Could not resolve to a PullRequest with the number of 465.

Example failing runs, both triggered by ordinary comments on issue #465:

This does not affect CLA enforcement on actual PRs (those runs pass), but every issue comment by anyone produces a red-X run in the Actions tab and burns a runner minute.

Proposal

Add the if: gate from cla-assistant's own setup instructions to the cla job:

if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the CLA Document and I hereby sign the CLA') || github.event_name == 'pull_request_target'

Comment-triggered runs then only fire for the two magic phrases (which only meaningfully occur on PRs), so plain issue chatter never reaches the action.

Acceptance criteria

  • Commenting on a non-PR issue triggers no CLA Assistant run (or a skipped one).
  • Signing via the magic phrase and recheck on a PR still work.
  • CLA enforcement on pull_request_target events is unchanged.

Happy to pick this up as a one-line follow-up.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open .github/workflows/cla.yml and inspect the cla job's issue_comment trigger and current conditions. Add the proposed if gate, then verify that ordinary issue comments do not run the action while the signing phrase, recheck comments on PRs, and pull_request_target enforcement still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, yaml
Domain
ci-cd
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
92/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.