Lint coverage for src/scripts/*.js
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 432
- Forks
- 51
- PR merge metrics
- No merged PRs in 30d
Description
Summary
ESLint does not cover the Node helper scripts under src/scripts/. The lint script runs eslint . from src/frontend (package.json → "lint": "cd src/frontend && npm run lint"), and the flat config's base path is src/frontend, so any file outside it is reported as "File ignored because outside of base path".
As a result, scripts like src/scripts/electron-dev.js, remove-locales.js, notarize.js, and sync-manifest-version.js are never linted in CI. They currently have to be checked by hand, e.g.:
node_modules/.bin/eslint --config src/frontend/eslint.config.js --no-config-lookup src/scripts/electron-dev.js
Proposal
Bring src/scripts/*.js into the lint path with a Node-oriented config block, and make npm run lint cover them automatically so they're checked in CI. Options to consider:
- A root-level flat config that includes both
src/frontendandsrc/scripts, or - A dedicated config block for
src/scripts/**/*.jswith Node globals and CommonJSsourceType.
These scripts are CommonJS Node (require/module.exports), so they need Node globals and sourceType: "commonjs" rather than the browser/React rules used for the frontend.
Acceptance criteria
npm run lintlintssrc/scripts/*.jswithout manual--no-config-lookupinvocations.- Existing scripts pass (or get fixed) under the chosen ruleset.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with package.json and src/frontend/eslint.config.js, then inspect the CommonJS files under src/scripts/*.js. Run the existing npm run lint command to reproduce the ignored-file behavior and compare the available config approaches. Done means npm run lint checks those scripts automatically and all existing scripts pass or have their lint issues fixed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- eslint, javascript
- Domain
- ci-cd, tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100