Allow custom base url

Open
#39 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Inspect python-lib/sharepoint_client.py around line 136 and trace how the tenant value is turned into the SharePoint host. Determine where a custom base URL can be supplied while preserving the existing default behavior. Done means connections to tenants using a non-standard host succeed without automatically appending .sharepoint.com.

Written by the indexing model from the issue text.

Description

My organization is using teamsite.<tenant>.com instead of normal <tenant>.sharepoint.com. Hence, when I tried to connect it returned following error:

Test failed: Failed to initialize kernel : <class 'robust_session.RobustSessionError'> : Error on attempt #5: HTTPSConnectionPool(host='teamsite.<tenant>.sharepoint.com', port=443): Max retries exceeded with url: /sites/<mysite>/_api/contextinfo (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7f219f728320>: Failed to establish a new connection: [Errno -2] Name or service not known',))

I suggest to not automatically append .sharepoint.com at the end of the tenant
https://github.com/dataiku/dss-plugin-sharepoint-online/blob/f7a9ef9f8584a77a9586dc12ec2f7b11870b999b/python-lib/sharepoint_client.py#L136

Dominant language
Python
Stars
4
Forks
7
Avg merge
17h 53m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dataiku/dss-plugin-sharepoint-online

All issues in dataiku/dss-plugin-sharepoint-online

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.