dataiku / dataiku/dss-plugin-googledrive
Unnecessary limitations on folder names
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
The function check_path_format at https://github.com/dataiku/dss-plugin-googledrive/blob/c988fec8021657a1901d57e6da46dcc431bd523c/python-lib/dku_googledrive/googledrive_utils.py#L133 contains a bunch of unnecessary checks on the folder names which can block ones permissible by Google Drive itself. The main issue is trailing space, which can happen in real Google Drive folders. This is an easy fix potentially, but I don't know if you're taking PRs.
You also cannot set a managed folder to the root path in DSS, but as far as I figured it out this is the general managed folder driver limitation. There's no reason it won't work with GDrive API itself though.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with check_path_format in python-lib/dku_googledrive/googledrive_utils.py at the linked lines and review each folder-name check against the behavior described for Google Drive folders. Done means permissible names, including names with trailing spaces, are no longer blocked; determine whether the separate root-path limitation belongs in this change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, cloud
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100