dataiku / dataiku/dss-plugin-api-connect

Infinite paging

Open
#42 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
4
Forks
4
Avg merge
3d 21h
Merged PRs (30d)
1

Description

I suppose that the paging stop incrementing when result become empty.

But with API that still send first page, event sending "pagingIndex=123...", the paging increment never stop (until server api drop for exceeding quota).

{ "content": "{\"totalCount\": 1, \"pageIndex\": 0, \"limit\": 50, \"isLastPage\": true, \"results\": .... }

Would it be possible to create parameter for "totalCount" or "isLastPage" key to check ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the REST pagination logic and its handling of empty results, then reproduce the supplied response with isLastPage or totalCount; done means pagination stops at the indicated final page and the relevant response key can be configured.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.