datafusion-contrib / datafusion-contrib/liquid-cache

Write more verifications for unsafe code

Open
#378 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
452
Forks
51
Avg merge
3h 10m
Merged PRs (30d)
12

Description

We currently added kani into our dev pipeline, which helps with verifying our unsafe usage.

One example usage: https://github.com/XiangpengHao/liquid-cache/blob/ea51a733b373b5f572764d106bfba846f8439eaa/src/storage/src/cache/cache_policies/doubly_linked_list.rs#L125-L185

We'd like to add a lot more, ideally, every unsafe function/usage should be verified with pre/post-conditions

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the Kani setup in the development pipeline and the example in src/storage/src/cache/cache_policies/doubly_linked_list.rs. Inventory the unsafe functions and usages that still lack verification, then define preconditions and postconditions for each. Done means the selected unsafe code is covered by passing Kani verification checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
security, testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.