datafusion-contrib / datafusion-contrib/datafusion-distributed
[Abstract protocol] Move non-gRPC protobuf messages to protobuf/
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 139
- Forks
- 67
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 35
Description
When abstracting gRPC details for the WorkerChannel abstraction, there are things that still live under the grpc scope that are not grpc specific: pretty much every message in worker.proto that is not the service definition.
It'd be nice to split the worker.proto file in two:
worker_service.proto: this will live under thegrpcscope, importing the messages frommessages.proto.messages.proto: root file on aprotobuf/module.
The protobuf/ module should not be gated behind the grpc flag, as it's something that probably anyone that is willing to implement a WorkerChannel should be using.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating worker.proto and tracing how its generated messages and service are exposed under the grpc feature. Split the definitions into worker_service.proto and messages.proto as described, with the messages in the protobuf module independent of grpc; done means WorkerChannel implementations can use those messages without enabling grpc.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- distributed-systems
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 66/100