databrickslabs / databrickslabs/pytester

[make_cluster] does not allow custom node_type_id

Open
#218 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
139
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Hey,

https://github.com/databrickslabs/pytester/blob/64fb32f32837c1d133c1691eb041920320e7bfd0/src/databricks/labs/pytester/fixtures/compute.py#L108

does not allow a custom node_type_id, if the "instance_pool_id" is not given. In my point of view this doesn't make sense, still I want to be able to match my cluster_policies requirements.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read src/databricks/labs/pytester/fixtures/compute.py around line 108 and trace how make_cluster handles node_type_id when instance_pool_id is absent. Confirm the expected behavior for a custom node_type_id and cluster-policy matching; the issue is done when make_cluster accepts that configuration without requiring an instance pool.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.