databrickslabs / databrickslabs/ontos

[Bug]: Domain Owners + Tags not saved

Open
#60 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status/needs-triage type/bug
Dominant language
Python
Stars
212
Forks
71
Avg merge
4d 10h
Merged PRs (30d)
43

Description

Is there an existing issue for this?
  • I have searched the existing issues
Current Behavior

When creating a new, or updating an existing domain owners (mandatory field!) and tags are not saved and always remain 'Not assigned', and 'None', respectively.

Expected Behavior

When creating a new, or updating an existing domain owners and tags are are saved properly.

Steps To Reproduce
  1. Create new domain.
    1. ``Provide a valid user email or group name in the owners field.
    2. Add a tag in the tags field.
  2. Open details of newly created domain.
    1. Observe 'Not assigned' under Owners
    2. Observer 'None' under Tags
  3. Press Edit and provide the information again.
  4. Observe the same results after editing.

Note: I have noticed that the DataDomainBase pydantic model does not contain any notion of owners. Should be added there?

Cloud

Azure

Browser

Edge

Version

latest

Relevant log output

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the DataDomainBase pydantic model mentioned in the issue, then trace how owners and tags are handled during domain creation and editing. Verify that the values are persisted and shown in the domain details after both creating and updating a domain.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.