databrickslabs / databrickslabs/ontos

[Feature]: Onboarding Profiling: Embed profiler in Asset Review editor

Open
#178 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

scope/asset-reviews type/feature
Dominant language
Python
Stars
212
Forks
71
Avg merge
4d 10h
Merged PRs (30d)
43

Description

Parent PRD

#172

What to build

Integrate the TableProfiler component into the Asset Review editor as the primary tab for table and view assets, replacing the existing basic preview.

Changes to AssetReviewEditor:

  • For assets of type table or view: render TableProfiler as the primary/default tab
  • The existing "preview" panel (basic SELECT *) is subsumed by the profiler's sample functionality
  • Existing "definition" tab (for views) and "Analyze with AI" become secondary tabs
  • For view assets: the profiler shows the info banner ("This is a view — profiling will execute the view's query against the warehouse")
  • For non-table/view asset types: existing behavior unchanged (no profiler tab)

Props wiring:

  • Pass fqn from the reviewed asset's asset_fqn
  • Pass assetType from the reviewed asset's asset_type
  • Pass initialSchema if the review editor already fetched column metadata (avoid duplicate UC API call)

Acceptance criteria

  • Opening a table asset in the review editor shows the profiler as the first/primary tab
  • Opening a view asset shows the profiler with the view warning banner
  • The existing basic preview is no longer shown separately (profiler's sample tab replaces it)
  • View definition and AI analysis are available as secondary tabs
  • Non-table/view assets (function, model, etc.) are unaffected — no profiler tab appears
  • Profiler errors (no warehouse, permission denied) are contained within the profiler panel and don't break the review editor

Blocked by

  • Blocked by #175 (Profiling tracer bullet)
  • Blocked by #173 (Fix critical bugs — ensures clean editor baseline)

User stories addressed

  • User story 10
  • User story 13
  • User story 22

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at AssetReviewEditor and TableProfiler, tracing the existing preview, definition, and AI-analysis tabs plus the asset_fqn and asset_type data. Check blockers #175 and #173 first; done means table and view assets show the profiler first, other tabs remain available, non-table/view behavior is unchanged, and profiler errors stay contained.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.