databrickslabs / databrickslabs/lsql
[BUG] Can't store concrete data classes that inherit from an abstract data class itself inheriting from ABC
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 39
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
Consider the following:
@dataclass
class AbstractDataclass(ABC):
name: str
@dataclass
class ConcreteDataclass(AbstractDataclass):
other: str
save_table will not store instances of ConcreteDataclass because ConcreteDataclass.__class__ is not a type
see backends.py line 350
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with backends.py at line 350 and reproduce the issue using the AbstractDataclass and ConcreteDataclass example from the report. Trace save_table's type check and verify that instances of the concrete subclass are stored successfully, including a regression test if the repository has an existing test location.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100