databrickslabs / databrickslabs/lsql

SqlBackend cannot create schema for dataclasses inheriting from dataclasses

Open
#103 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
39
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Say you have the following:

@dataclass
class MyBaseDataClass:
    path: str

@dataclass
class MyDerivedDataClass(MyBaseDataClass):
    name: str

Then SqlBackend._schema_for fails because field_type for path is 'str' (type name) rather than <type str> (type instance)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting SqlBackend._schema_for and reproduce the failure with the inherited dataclass example in the issue. Check how inherited fields are represented and verify that schema creation succeeds for both path and name without changing behavior for non-inherited dataclasses.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.