[coverage] Conformance findings: SESSION-017
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
Research direction
Start with TestTelemetryEnablementPropertyIsHonoredAndOptional in the coverage PR diff under tests/, then trace the Go driver's DSN parsing and connect-time telemetry-property handling. Confirm the driver's own spelling for EnableTelemetry. Done means malformed values allow the connection to open, preserve the default, and produce the specified warning diagnostic while valid and absent values continue to work.
Written by the indexing model from the issue text.
Description
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-go. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-go) is fixed, then flips green as a tripwire.
Findings
- SESSION-017 [thrift]: A malformed enableTelemetry DSN value is fatal: ParseDSN rejects the entire DSN (strconv.ParseBool error) so the connection never opens, instead of leaving the telemetry overlay default untouched and diagnosing the typo
- failing test:
TestTelemetryEnablementPropertyIsHonoredAndOptional(see the coverage PR diff undertests/)
- failing test:
Reproduce & Expected
SESSION-017 — Validates the connect-time contract of the driver's telemetry-enablement connection property (reference ODBC key EnableTelemetry; map to the driver's own spelling for the SAME concept, e.g.
Reproduce:
SELECT 1 AS value
SELECT 1 AS value
SELECT 1 AS value
SELECT 1 AS value
Expected (per the shared spec):
- completes without an exception
- result has exactly 1 row(s)
- col 0 is named
value - completes without an exception
- result has exactly 1 row(s)
- completes without an exception
- result has exactly 1 row(s)
- completes without an exception
- result has exactly 1 row(s)
- full assertion contract:
result:
- label: opt_in
no_exception: true
- label: opt_in
row_count: 1
- label: opt_in
column:
index: 0
name: value
- label: opt_in
warning_diagnostic:
mentions: EnableTelemetry
present: false
- label: opt_out
no_exception: true
- label: opt_out
row_count: 1
- label: opt_out
warning_diagnostic:
mentions: EnableTelemetry
present: false
- label: malformed
no_exception: true
- label: malformed
row_count: 1
- label: malformed
warning_diagnostic:
mentions: EnableTelemetry
present: true
sql_state: 01S02
- label: absent
no_exception: true
- label: absent
row_count: 1
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-odbc/pull/333 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-go; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1641
- Dominant language
- Go
- Stars
- 53
- Forks
- 66
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 21
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from databricks/databricks-sql-go
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
databricks/databricks-sql-go#476 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
databricks/databricks-sql-go#480 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
databricks/databricks-sql-go#475 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
databricks/databricks-sql-go#474 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 62/100
databricks/databricks-sql-go#473 ·
All issues in databricks/databricks-sql-go
Similar issues
-
Type/Bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
OpenNSW/nsw-srilanka#497 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
milvus-io/birdwatcher#545 ·
-
kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/prow#953 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
caddyserver/caddy#8046 ·