dasm-assembler / dasm-assembler/dasm
remove the strict mode flag (or revert its meaning)
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 257
- Forks
- 55
- PR merge metrics
- No merged PRs in 30d
Description
Why should an obviously wrong statement be no error without the strict mode flag ?
Assembly language is difficult to learn and understand. Tools should help us and not hiding errors. Strict mode should be the default/always on. If legacy code would not assemble you probably have either a long forgotten bug inside or it was related to issue #64 where error codes from the first pass persisted.
This is a follow-up to issue #60. Imagine the value would be calculated from other symbols. You include some additional code, the value grows and will not fit into the desired space/register. The result would be definitely wrong code. Would you like to allow it ?
BTW: The deleted 'positive' testcases would fail also without strict mode flag. I recommend to include also commit a999a9d into the pull request.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review issue #60, issue #64, and commit a999a9d first, then inspect the strict-mode handling and the deleted positive test cases. Done means deciding the intended strict-mode behavior and ensuring obviously invalid statements are rejected without relying on the flag, while the relevant positive cases remain covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100