dask / dask/distributed

`distributed/shuffle/tests/test_shuffle.py::test_clean_after_close`

Open
#6,405 1 comment 0 reactions 0 assignees View on GitHub
flaky test
Dominant language
Python
Stars
1.7k
Forks
778
Avg merge
2h 50m
Merged PRs (30d)
3

Description

Occurred on https://github.com/dask/distributed/pull/6400 but I've seen it in other PRs as well
https://github.com/dask/distributed/runs/6524459060?check_suite_focus=true
```
____________________________ test_clean_after_close ____________________________

c =
s =
a =
b =

@gen_cluster(client=True)
async def test_clean_after_close(c, s, a, b):
df = dask.datasets.timeseries(
start="2000-01-01",
end="2000-01-10",
dtypes={"x": float, "y": float},
freq="10 s",
)
x = dd.shuffle.shuffle(df, "x", shuffle="p2p").persist()

while not s.tasks or not any(ts.state == "memory" for ts in s.tasks.values()):
await asyncio.sleep(0.01)

await a.close()
> clean_worker(a)

distributed/shuffle/tests/test_shuffle.py:460:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

worker =

def clean_worker(worker):
"""Assert that the worker has no shuffle state"""
> assert not worker.extensions["shuffle"].shuffles
E AssertionError: assert not {'6d5abfdcdfeb8f0fe8f7ad64604df132': }
E + where {'6d5abfdcdfeb8f0fe8f7ad64604df132': } = .shuffles

distributed/shuffle/tests/test_shuffle.py:30: AssertionError
----------------------------- Captured stdout call -----------------------------
Dumped cluster state to test_cluster_dump/test_clean_after_close.yaml
----------------------------- Captured stderr call -----------------------------
2022-05-20 14:23:59,127 - distributed.core - ERROR - Exception while handling op shuffle_receive
Traceback (most recent call last):
File "/home/runner/work/distributed/distributed/distributed/shuffle/shuffle_extension.py", line 347, in _get_shuffle
return self.shuffles[shuffle_id]
KeyError: '6d5abfdcdfeb8f0fe8f7ad64604df132'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/home/runner/work/distributed/distributed/distributed/core.py", line 585, in handle_comm
result = await result
File "/home/runner/work/distributed/distributed/distributed/shuffle/shuffle_extension.py", line 252, in shuffle_receive
shuffle = await self._get_shuffle(shuffle_id)
File "/home/runner/work/distributed/distributed/distributed/shuffle/shuffle_extension.py", line 370, in _get_shuffle
shuffle = Shuffle(
File "/home/runner/work/distributed/distributed/distributed/shuffle/shuffle_extension.py", line 67, in __init__
self.multi_file = MultiFile(
File "/home/runner/work/distributed/distributed/distributed/shuffle/multi_file.py", line 68, in __init__
os.mkdir(self.directory)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmp5zq6vygj/dask-worker-space/worker-_36t5f_y/shuffle-6d5abfdcdfeb8f0fe8f7ad64604df132'
2022-05-20 14:23:59,130 - distributed.core - ERROR - Exception while handling op shuffle_receive
Traceback (most recent call last):
File "/home/runner/work/distributed/distributed/distributed/shuffle/shuffle_extension.py", line 347, in _get_shuffle
return self.shuffles[shuffle_id]
KeyError: '6d5abfdcdfeb8f0fe8f7ad64604df132'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/home/runner/work/distributed/distributed/distributed/core.py", line 585, in handle_comm
result = await result
File "/home/runner/work/distributed/distributed/distributed/shuffle/shuffle_extension.py", line 252, in shuffle_receive
shuffle = await self._get_shuffle(shuffle_id)
File "/home/runner/work/distributed/distributed/distributed/shuffle/shuffle_extension.py", line 370, in _get_shuffle
shuffle = Shuffle(
File "/home/runner/work/distributed/distributed/distributed/shuffle/shuffle_extension.py", line 67, in __init__
self.multi_file = MultiFile(
File "/home/runner/work/distributed/distributed/distributed/shuffle/multi_file.py", line 68, in __init__
os.mkdir(self.directory)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmp5zq6vygj/dask-worker-space/worker-_36t5f_y/shuffle-6d5abfdcdfeb8f0fe8f7ad64604df132'
```

There are also a few rare failures on main

![image](https://user-images.githubusercontent.com/8629629/169583644-343c0af0-289a-49ea-bc97-cead81666bc6.png)

https://github.com/dask/distributed/actions/runs/2356436925
https://github.com/dask/distributed/actions/runs/2292297969

cc @mrocklin

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.