dask / dask/distributed

Investigate asyncio.wait_for for possible bug

Open
#6,211 5 comments 0 reactions 0 assignees View on GitHub
asyncio
Dominant language
Python
Stars
1.7k
Forks
778
Avg merge
2h 50m
Merged PRs (30d)
3

Description

I've encountered situations that I think point to asyncio.wait_for not actually cancelling the underlying coroutine if the timeout is reached. I've had to work around this in a couple of situations:

- https://github.com/dask/distributed/pull/6155
- https://github.com/dask/distributed/pull/6186

See for a possible root cause: https://github.com/python/cpython/issues/86296

We use `asyncio.wait_for` commonly throughout the codebase. If it genuinely sometimes misses then we should find a workaround, including possibly writing this ourselves.

cc @graingert do you have any thoughts on the CPython bug? Could it be causing what we're seeing? Do you see an easy solution here?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.