dask / dask/distributed

Client.get_versions(check=True) not behaving as expected from docs

Open
#5,731 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
1.7k
Forks
778
Avg merge
2h 50m
Merged PRs (30d)
3

Description

The documentation in question

```
raise ValueError if all required & optional packages do not match
```

A quick look at the [tests](https://github.com/dask/distributed/blob/e31bc264dbb14be26e64693210e0eb5563440e89/distributed/tests/test_versions.py) around this feature and I don't see any `with pytest.raises` blocks i'd expect.

From looking at`error_message` https://github.com/dask/distributed/blob/e31bc264dbb14be26e64693210e0eb5563440e89/distributed/versions.py#L156-L165)

The 'error' category will never have anything added to it.

Having the ability to raise an exception and not just a warning is valuable and a little easier to think about than catching the warnings.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.