dask / dask/distributed

Support JupyterLab dark mode in dashboard plots

Open
#5,200 2 comments 0 reactions 1 assignee Claimed by @ian-r-rose View on GitHub
diagnostics
Dominant language
Python
Stars
1.7k
Forks
778
Avg merge
2h 50m
Merged PRs (30d)
3

Description

When using the dask labextension, plots are hard to read in dark mode because some of the colors don't adjust:

![Screen Shot 2021-08-10 at 9 31 54 PM](https://user-images.githubusercontent.com/3309802/128965605-cbbdddd5-77ff-4209-a732-8ffcf4b9539d.png)

Text colors do change (titles, ticks) but others don't. Even just getting the grid lines to be dark instead of light would be 90% of the way to usability.

That said, I highly doubt there's a way for the dashboard to actually know it's being viewed by JupyterLab in dark mode. Since the plots are all iframe'd, we couldn't even do it with CSS variables that Jupyter sets, right? Maybe the extension could inform the scheduler to please change its dashboard theme?

xref https://github.com/dask/distributed/issues/2305, https://github.com/jupyterlab/jupyterlab/issues/3855

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.