dask / dask/distributed

Nanny.close should gracefully close worker

Open
#2,779 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.7k
Forks
778
Avg merge
2h 50m
Merged PRs (30d)
3

Description

Currently `Nanny.close` just terminates the worker process. Probably it should send a close signal

```python
future = self.rpc(self.worker_address).terminate(nanny=False)
```

And then wait on that future for a suitable time

```python
with ignoring(gen.TimeoutError):
yield gen.with_timeout(timedelta(seconds=timeout/2), future)
```

I'm not sure that this gets the job done though. When I tried this there were still some lingering comms around.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.