dask / dask/dask-ml

Should Incremental.partial_fit be concrete when handed numpy arrays?

Open
#234 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
951
Forks
262
PR merge metrics
No merged PRs in 30d

Description

What should happen here?

```python
sgd = skleran.SGDClassifier()
inc = Incremental(sgd)

X = np.array(...)
y = np.array(...)
inc.partial_fit(X, y)
```

Everything is concrete. Should we build things up lazily or should we execute directly using `inc.estimator.partial_fit(X, y)`?

Contributor guide

Open the contributing guide

Research direction

Start with the Incremental.partial_fit entry point and compare it with inc.estimator.partial_fit(X, y) for the concrete NumPy-array example in the issue. Resolve whether this path should remain lazy or execute directly, then define and test the agreed behavior for concrete inputs.

Written by the indexing model from the issue text.

Assessment

Tech stack
numpy, python, scikit-learn
Domain
machine-learning
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.