dask / dask/dask-kubernetes

Question about dask operator logic

Open
#932 1 comment 0 reactions 0 assignees View on GitHub
question
Dominant language
Python
Stars
324
Forks
157
PR merge metrics
No merged PRs in 30d

Description

Wanted to ask a few questions about [this PR](https://github.com/dask/dask-kubernetes/pull/661) that was changing the Dask Kubernetes settings / configuration.

**Firstly,** I may be confused about the `async` addition for `_is_service_available` and what that is doing. I see that it is used in two functions (`get_external_address_for_scheduler_service` and `get_internal_address_for_scheduler_service`) but both of these functions were `async` already. So if used from an async context, I would assume that they would already be non-blocking. Especially since `_is_service_available` is called with `await` I am confused what this modification does. I am not a heavy python async user so please explain like I am 5 years old.

**Secondly,** a friend I have had some concerns about `periodSeconds` being set to `1` , specifically he was under the impression that `timeoutSeconds=300` would cause K8 to create 300 concurrent requests if the health point in question is not responding. I am also relatively new to the liveness probe behavior, is it your understanding that these a probe request will only be created after a probe fails, or that probes may be concurrent?

cc: @jacobtomlinson

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.