dask / dask/dask-gateway

Add better support of local settings for shared traefik ingress controller

Open
#909 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
148
Forks
93
PR merge metrics
No merged PRs in 30d

Description

# Problem
When deploying the gateway in Kubernetes using the helm chart, setting `traefik.installTraefik` to `false` doesn't allow enough customization to work with existing ingress controller settings. In this situation it's impossible to deploy a working gateway with a shared traefik ingress controller.

# Additional Customizations Needed
1. The gateway ingressroute need to match on host as well as path prefix. It also needs to use site specific `entryPoint` values
2. The proxy tcp ingress route needs to allow setting of value for `entryPoint` not just `web` or `tcp` from the `tcp.port` value
3. The dashboard proxy ingressroutetcp needs to match on host as well as path prefix and also needs to use site specific `entryPoint`

There may be other considerations, but these were the minimum to get the gateway running on our cluster.

I tested this out in my fork and was able to deploy a gateway using our shared traefik controller.

If you think this is a useful change, I can make a PR for your consideration.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.