dart-lang / dart-lang/webdev

Make ExpressionCompiler parameter in Dwds.start required

Open
#881 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Dart
Stars
224
Forks
94
Avg merge
7h 14m
Merged PRs (30d)
2

Description

Currently, if it is null, Dwds will revert to previous behavior of throwing unimplemented exception on expression evaluation. After expression all scenarios in flutter support both Dwds and frontend_server, make this parameter required to avoid future breaks.

See:

Not yet - I will change it to be required after a version of dwds including those changes is picked up by flutter/flutter, to simplify merging. If expressionCompiler is not given, dwds will simply fall back to previous behavior on evaluteInFrame (ie throwing unsupported exception)

_Originally posted by @annagrin in https://github.com/dart-lang/webdev/pull/879_

Contributor guide

Open the contributing guide

Research direction

Start at the Dwds.start entry point and inspect its expressionCompiler parameter and callers, including evaluateInFrame behavior mentioned in the issue. The change is complete when expressionCompiler is required and the existing fallback behavior is no longer possible, while expression evaluation continues to work for the supported scenarios.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
cli, tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.