dart-lang / dart-lang/webdev

The `targetId` argument in `evaluate` might not be a library ID

Open
#2,336 0 comments 0 reactions 0 assignees View on GitHub
P2 package:dwds triaged
Dominant language
Dart
Stars
224
Forks
94
Avg merge
7h 14m
Merged PRs (30d)
2

Description

DWDS currently assumes that the `targetId` argument in `evaluate` is always a library ID:

https://github.com/dart-lang/webdev/blob/6cad2b0021072bb773d1dd621b9d03a3ecebf602/dwds/lib/src/services/chrome_proxy_service.dart#L621

This is not the case, `targetId` might be a library, class or instance: https://github.com/dart-lang/webdev/blob/6cad2b0021072bb773d1dd621b9d03a3ecebf602/dwds/lib/src/services/chrome_proxy_service.dart#L621

Contributor guide

Open the contributing guide

Research direction

Start at dwds/lib/src/services/chrome_proxy_service.dart around line 621 and trace how evaluate uses targetId. Check how library, class, and instance targets are represented and handled there; done means evaluate no longer assumes targetId is always a library ID.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.