dart-lang / dart-lang/test

Workflow for removing skip from newly passing tests

Open
#665 3 comments 0 reactions 0 assignees View on GitHub
type-enhancement
Dominant language
Dart
Stars
536
Forks
232
Avg merge
1d 10h
Merged PRs (30d)
10

Description

What should be the recommended workflow for removing `skip: true` from newline passing tests?

Let's say I have a huge test suite, with a few dozen `skip: true` tests, and I make a big refactor:

1. I run `pub run test --run-skipped` to see if any have failed. Oh, 37 failed.
2. But how many do I have skipped? Run `git grep "skip: true"`. 39 skipped!
3. Now how do I find the 2 that I fixed during the refactor?

I've been doing tricks with `pub run test |grep skip`, but this is still very icky when you have > 10 or so skipped tests.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the reported workflow with `pub run test --run-skipped`, `git grep "skip: true"`, and the existing `pub run test | grep skip` workaround. Review the test runner's skipped-test output and determine whether a recommended workflow can be documented; done means a newcomer can identify newly passing skipped tests without manual comparison.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
testing
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.