dart-lang / dart-lang/test

Matcher should always call describeMismatch of a nested macther

Open
#2,333 5 comments 1 reaction 0 assignees View on GitHub
package:matcher type-bug
Dominant language
Dart
Stars
536
Forks
232
Avg merge
1d 10h
Merged PRs (30d)
10

Description

_Originally opened as dart-lang/sdk#14068_

_This issue was originally filed by wolf....@gmail.com_

---

**What steps will reproduce the problem?**
1. Create a Matcher with has a describeMismatch method
2. Create a falling unittest with the Matcher in the isNot-Matcher: isNot(myMatcher)

**What is the expected output? What do you see instead?**
Expected:

---

Expected: not <my description>
  Actual: <value>
   Which: <my mismatch description>

Actual:

---

Expected: not <my description>
  Actual: <value>

**What version of the product are you using? On what operating system?**
Dart VM version: 0.8.1.2_r28355 (Tue Oct 08 06:29:27 2013) on "windows_ia32"

**Please provide any additional information below.**
All matcher that contain other matcher should add the nested description. At least isNot is missing that.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the failing unittest with a custom matcher nested inside isNot, then trace how the nested matcher’s describeMismatch result is handled. Done means the failure output includes a Which line with the nested mismatch description, matching the expected output in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.