dart-lang / dart-lang/native

[hook_runner] Use `ProcessManager` and `FileSystem`

Open
#90 2 comments 0 reactions 0 assignees View on GitHub
contributions-welcome P3 package:hooks_runner type-code-health
Dominant language
Dart
Stars
275
Forks
144
Avg merge
2d 10h
Merged PRs (30d)
47

Description

[flutter_tools unit tests](https://github.com/flutter/flutter/tree/master/packages/flutter_tools/test/commands.shard) are split into hermetic and permeable tests.

The hermetic tests mock the file system and process invocations.

* Mocking processes: https://pub.dev/packages/process
* Mocking file system: https://pub.dev/packages/file

The native_assets_builder does not use these abstractions, and will try to read/write the local file system and do process invocations.

This means we cannot write hermetic unit tests for the native assets feature, and that we have to always skip the check for native assets in the hermetic unit tests.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.