dart-lang / dart-lang/dart-vim-plugin

Syntax is not hightlighted properly on nestedBraces test

Open
#144 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Vim Script
Stars
653
Forks
51
PR merge metrics
No merged PRs in 30d

Description

It looks like current syntax region used for matching string isn't matching the braces properly. Braces those are a string are being read as braces.

Test file: https://github.com/dart-lang/dart-syntax-highlight/blob/master/test/test_files/string_interpolation.dart#L26C1-L26C52

Expected result (Visual Studio Code):
![image](https://github.com/dart-lang/dart-vim-plugin/assets/45139213/700e3b6a-d43a-42ec-9f05-ab43a33870f2)

Actual result (Vim):
![image](https://github.com/dart-lang/dart-vim-plugin/assets/45139213/12e9f6d0-a45b-4e02-a0f8-f24bbc6026ed)

Contributor guide

Open the contributing guide

Research direction

Start with test/test_files/string_interpolation.dart at line 26 and inspect the syntax region used for matching strings and braces in the Vim plugin. Reproduce the nestedBraces highlighting case, then verify that braces inside the string are not read as interpolation braces and the result matches the expected highlighting shown in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
vim
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.