darktable-org / darktable-org/rawspeed

addCamera method should be declared as protected

Open
#767 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
456
Forks
147
PR merge metrics
No merged PRs in 30d

Description

There is a comment in the source of the class CameraMetaData which reads

// NOTE: *NOT* `final`, could be derived from by downstream.
class CameraMetaData {
public:
  CameraMetaData() = default;

// omitted code

private:
  const Camera* addCamera(std::unique_ptr<Camera> cam);
};

A class that derives from CameraMetaData most likely wants to add camera metadata in its own constructor. For this purpose, grating access to the addCamera method by declaring it as protected would be very convenient. As of the current implementation of CameraMetaData, each derived class needs to implement its own variant of the addCamera method (or implement the functionality of addCamera directly in its constructor).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the CameraMetaData class declaration and its addCamera method. Confirm that derived classes need access while preserving the existing behavior, then build or run the repository's available checks to verify the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.