darktable-org / darktable-org/rawspeed
`RawImageDataU16::calculateBlackAreas()` only looks at a single pixel o_O
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 456
- Forks
- 147
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/darktable-org/rawspeed/blob/990cec748fbb98ef5d5f9347fde013ce34dff2b8/src/librawspeed/common/RawImageDataU16.cpp#L76-L82
https://github.com/darktable-org/rawspeed/blob/990cec748fbb98ef5d5f9347fde013ce34dff2b8/src/librawspeed/common/RawImageDataU16.cpp#L93-L99
^ nowhere in these loop do we advance the pixel pointer...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/librawspeed/common/RawImageDataU16.cpp at lines 76-82 and 93-99, then trace how the pixel pointer is used in each loop. Done means calculateBlackAreas examines the intended pixels rather than repeatedly processing only one pixel.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100