darktable-org / darktable-org/rawspeed
CFA tag is relative to the Crop XY
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 456
- Forks
- 147
- PR merge metrics
- No merged PRs in 30d
Description
CFA2 is not, thankfully.
So e.g. if we have:
<Camera make="Panasonic" model = "DMC-FZ28">
<ID make="Panasonic" model="DMC-FZ28">Panasonic DMC-FZ28</ID>
<CFA width="2" height="2">
<Color x="0" y="0">BLUE</Color>
<Color x="1" y="0">GREEN</Color>
<Color x="0" y="1">GREEN</Color>
<Color x="1" y="1">RED</Color>
</CFA>
<Crop x="0" y="0" width="-56" height="-4"/>
<Sensor black="15" white="3986"/>
</Camera>
If we change crop x/y by a multiple of two, everything is fine.
But if we change it by just one, we also need to adjust <CFA>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the raw-decoding handling for the and elements, then compare the sample configuration with crop offsets that differ by one. Done means changing the crop origin by an odd amount preserves the intended CFA pattern without requiring a manual CFA adjustment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100