darktable-org / darktable-org/rawspeed
RawImageData{U16,Float}::fixBadPixel() should be deduplicated
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 456
- Forks
- 147
- PR merge metrics
- No merged PRs in 30d
Description
Code duplication leads to bugs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating RawImageDataU16::fixBadPixel() and RawImageDataFloat::fixBadPixel(), then compare their implementations and callers. Check existing tests covering bad-pixel correction; done means the duplicated logic is consolidated without changing either type's behavior and the relevant tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100