darktable-org / darktable-org/rawspeed
TableLookUp needs a rewrite.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 456
- Forks
- 147
- PR merge metrics
- No merged PRs in 30d
Description
Just completely broken. https://github.com/darktable-org/rawspeed/pull/138/commits/d4be7f42e9bbb58e0033006852f85c6fa7343916 https://github.com/darktable-org/rawspeed/pull/138/commits/4ebeddc4a2562846be48c7a6adbf552887bd8fc9
Should be rewritten (with tests!) cleanly, to something much like the Spline (1, 2)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the two linked commits for the broken TableLookUp behavior, then read src/librawspeed/common/Spline.h and test/librawspeed/common/SplineTest.cpp as the stated reference. Done means a clean TableLookUp rewrite accompanied by tests, with the expected behavior established from that comparison.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 18/100