darktable-org / darktable-org/lua-scripts

Don't delete unused tags in path of attached ones

Open
#326 22 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
219
Forks
142
PR merge metrics
No merged PRs in 30d

Description

With PR 8270 you can convert nodes of hierarchical tags to new tags.
As no images are attached to this new tag directly, the lua script delete_unused_tags would delete this tag again.

I would like to adapt the lua-script so that non attached tags in the path of an attached one are not deleted

Is it ok to edit the existing script?

I yes - I will open a Pull Request

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Lua script named delete_unused_tags and review PR 8270 to understand how converted hierarchical tags are represented. Update the script so non-attached tags in the path of an attached tag are retained, then verify that unused tags outside such paths are still deleted.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.