darktable-org / darktable-org/darktable

Search filmroll does not update collection

Open
#9,931 8 comments 0 reactions 1 assignee View on GitHub

@AlicVB is already working on this.

Since Feb 6, 2022.

bug: pending no-issue-activity scope: DAM scope: UI
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

In DT git master there are some gui glitches in the collections lib.
To reproduce:

  1. Import a few film rolls
  2. with DT closed, rename on purpose the folder of one film roll
  3. Open DT, the renamed film roll is shown in the collections lib with a strikethrough
  4. Right-click on the film roll and select "search film roll..."
  5. Select the renamed folder

Expected behavior: according to the code in view_popup_menu_onSearchFilmroll()


      /* reset filter so that view isn't empty */
      dt_view_filter_reset(darktable.view_manager, FALSE);

      /* update collection to view missing filmroll */
      _lib_folders_update_collection(new_path);

      DT_DEBUG_CONTROL_SIGNAL_RAISE(darktable.signals, DT_SIGNAL_FILMROLLS_CHANGED);

The filmroll name in the treeview should no longer be strikethrough. The collection should not be empty, the found film roll should be visualized.

Observed behavior: The filmroll name is still strikethrough and stays so until a DT restart. The collection is empty. The lib reset button does not work until one of the filmrolls is selected with a double click

EDIT: by the above code calls _lib_folders_update_collection(new_path); but new_path is never used inside the function.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.