darktable-org / darktable-org/darktable

Hide presets in darkroom doesm't hide presets in module groups, but hide presets in lightable does

Open
#8,529 10 comments 0 reactions 1 assignee View on GitHub

@AlicVB is already working on this.

Since Mar 21, 2021.

bug: pending feature: enhancement no-issue-activity scope: UI
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Describe the bug/issue

When you want to hide the default built-in presets in the presets for module groups, "hide built-in presets for processing module" from darkroom preference window does not hide the presets for module group (ie modules: all, modules: default, modules deprecated, searchonly, workflow: beginner, workflow: display-referred, workflow: scene-referred).
To hide the the presets for module group (ie modules: all, modules: default, modules deprecated, searchonly, workflow: beginner, workflow: display-referred, workflow: scene-referred), you have to check the "hide built-in presets for utility modules", in the lightable tab of the preferences window.

In short, a lighttable preferences should not have action in the darkroom preferences, when there is already the same preferences.

To Reproduce
Go to darkroom
Click on preset hamburger menu (module group)
Check the built-in presets are displayed
Open Preferences window
Go to darkroom tab
Check "hide built-in presets for processing module".
Close window
Click on preset hamburger menu (module groups)
Check the built-in presets are still displayed

Open Preferences window
Go to darkroom tab
Uncheck "hide built-in presets for processing module".
Go to lightroom tab
Check hide built-in presets for utility module.
Close window
Click on preset hamburger menu (module group)
Check the built-in presets are hidden.

Expected behavior
When you check the default built-in presets in the presets for module groups, "hide built-in presets for processing module" from darkroom preference window, the built-in presets in the presets for module groups should hide.

The behaviour exists in Darktable 3.4, 3.4.1, darktable-3.5.0+1491_g6b996cd9f

Platform
_Please fill as much information as possible in the list given below. Please state "unknown" where you do not know the answer and remove any sections that are not applicable _

  • darktable version : darktable-3.5.0+1491_g6b996cd9f
  • OS : macos big sur 11.1.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.