darktable-org / darktable-org/darktable

Switching to QAP blocked when certain modules are active

Open
#22,336 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug

Since https://github.com/darktable-org/darktable/pull/22286 made switching to QAP is safer in the sense, that no hidden masking controls etc. can be active when switching to the QAP. Fixing various issues I reported in https://github.com/darktable-org/darktable/issues/22169. But the fix also stops one in their tracks requiring to remember what tool/module is open and closing it before switching to the QAP, which feels clumsy.

I usually access the QAP thorugh a keyboard shortcut, so I solved this issue for myself by assigning a lua script to my qap-keyboard-shortcut that defocusses the currently focussed module and then switches to the QAP by triggering:

dt.gui.action("iop/focus", "focus", "toggle", 1.000)
dt.gui.action("lib/modulegroups/quick access panel", "", "on", 1.000)

But I suspect there must be a more elegant way of solving this issue.

I lack the deep understanding of the code to make a suggestion to fix it. But judging from the fix I employed for myself I am wondering whether attaching "defocus focussed module" to the QAP button might be the right thing to do?

Steps to reproduce

Open a module
Enable masking
Place a drawn mask
Try to switch to QAP >> Blocked

or open the crop module so that the crop handles are visible
try to switch to QAP >> Blocked

Expected behavior

Clean up open modules before switchting to QAP by itself

Logfile | Screenshot | Screencast

No response

Commit

https://github.com/darktable-org/darktable/pull/22286

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

Darktable-5.7.0+957

What OS are you using?

Linux

What is the version of your OS?

bazzite

Describe your system

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

irrelevant

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request 22286 and the QAP and module-focus actions shown in the report. Reproduce the block with an active mask or visible crop handles, then trace how switching to QAP handles those active modules; done means QAP switches automatically while cleaning up the open controls.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, lua
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.