darktable-org / darktable-org/darktable

Shortcut when using multiple instances break after darktable restart

Open
#22,308 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

scope: UI
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug

Shortcuts get broken after DT reset - I think this happens if theres a "first" option in the effect collumn, as well as a "first" option in the instance collumn. If I then set a shortcut that should apply to "first" instance, after a restart moves the first to effect.... They share the same name, whatever loads/saves the shortcut gets confused..?

Steps to reproduce
  • Go to settings
  • Set a shortcut, for example here illuminant, since it has a dropdown menu and the first options - that breaks consistently, popups do too... anything that has a "first" in effect i would guess, or just an effect+instance named the same.
Image
  • Shortcut works as intended for this launch

  • Restart darktable

  • Check settings: the "first" has moved into the effect collumn, shortcut is now broken...

Image
Expected behavior

Keep the settings as set

darktable version

5.7.0+923.g6a2f19f4e3, though I feel like this has been an issue on earlier versions too, its just that my workflow now requires to have more instances of modules on and this makes shorcuts useless.

What OS are you using?

Linux

What is the version of your OS?

CachyOS

Are you using OpenCL GPU in darktable?

Yes

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in darktable 5.7.0+923.g6a2f19f4e3 by assigning a shortcut to the first instance of Illuminant, then restart and inspect the shortcut settings. Trace the shortcut save/load handling for effect and instance names that are both "first"; done means the assignment remains associated with the instance after restarting.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.