darktable-org / darktable-org/darktable

Using haze removal results in dark rectangle(s) along bottom of image

Open
#22,241 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

OpenCL scope: image processing
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

Is there an existing issue for this?
  • I checked and did not find my issue in the already reported ones
Describe the bug

When I use the haze removal module, a dark rectangle (or several dark rectangles) appears along the bottom of an image.

The following is a sample when I have used haze removal.

Image

The following is a sample when I use the history module to turn off haze removal

Image
Steps to reproduce
  1. Edit an image produced by DxO Pure RAW 6 from a RAW file on a Canon EOS R5 m2
  2. Crop to taste.
  3. Use color calibration to change the WB to the same as the pipeline.
  4. Use AgX to set the black point (to -5.76 EV) and brighten the image slightly.
  5. (I then started to use color balance rgb, but stopped, so it did nothing)
  6. Use the haze removal module to increase strength (to 0.27)
Expected behavior

darktable should not create dark rectangles along bottom of image.

Logfile | Screenshot | Screencast

The following is the log file:

darktable-log.txt

Commit

No response

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

5.6.1

What OS are you using?

Windows

What is the version of your OS?

Windows 11

Describe your system
Device name	SurfaceStudio2
Processor	13th Gen Intel(R) Core(TM) i7-13700H (2.90 GHz)
Installed RAM	64.0 GB (63.8 GB usable)
Graphics card	NVIDIA GeForce RTX 4060 Laptop GPU (8 GB)
Intel(R) Iris(R) Xe Graphics (128 MB)
Storage	1.14 TB of 1.86 TB used
Device ID	B2F187D8-8762-4AB7-A92B-11EBF85371A5
Product ID	00356-06297-50847-AAOEM
System type	64-bit operating system, x64-based processor
Pen and touch	Pen and touch support with 10 touch points
Are you using OpenCL GPU in darktable?

I dont know

If yes, what is the GPU card and driver?

NVIDIA GeForce RTX 4060 Laptop GPU (8 GB) Intel(R) Iris(R) Xe Graphics (128 MB)

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

I saw this also with darktable 5.6.0
This only seems to happen on RAW files or DNG files
The reproduction is sporadic, and I haven't tried it with a fresh edit.

The following is the xmp file that generated the output:

_GTL0785-CR3_DxO_DeepPRIME.dng.xmp.txt

I can send the .dng file but it seems to never upload to github, even if I change the suffix to .txt...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the artifact using the attached XMP and the reported RAW or DNG workflow, then compare the haze-removal result with the history-disabled result. Use the attached logfile to determine whether the issue follows the GPU/OpenCL path or the image-processing path. Done means the haze-removal module no longer produces dark rectangles on the supplied workflow and regression coverage exists for the failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
computer-vision
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.