darktable-org / darktable-org/darktable

percentage and pixel for crop module

Open
#22,238 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

scope: image processing scope: UI
Dominant language
C
Stars
13.1k
Forks
1.4k
Avg merge
22h 14m
Merged PRs (30d)
198

Description

The crop module in freehand mode only supports percentages.
As the resolution of RAW and JPEG images created by cameras can differ, it would be helpful to be able to crop by specifying the pixel margin rather than just a percentage. That way, it would be easy to match the resolution of the exported RAW images to the resolution of the native images.

Another way to do it would be to specify the horizontal and vertical resolutions (instead of the margins), provided the crop is centred.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the crop module and its freehand mode, then trace how percentage margins are exposed and applied. Determine how pixel margins or centered horizontal and vertical resolutions should be represented, and verify the result against RAW and JPEG images with different resolutions.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
computer-graphics, desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.